diff options
author | Carlo Zancanaro <carlo@zancanaro.id.au> | 2015-06-01 13:10:49 +1000 |
---|---|---|
committer | Carlo Zancanaro <carlo@zancanaro.id.au> | 2015-06-01 13:10:49 +1000 |
commit | 816a5b89c5ddb8e295b8e8e46075da3cb694b2a7 (patch) | |
tree | 4e2d6657e7de96506cf3f3e40572fbb1a2ddf6b4 /src/main/java/au/id/zancanaro/javacheck/RoseTree.java | |
parent | a0d8c8066faadaf609e151ed0b71235a9615584a (diff) |
Fix up static analysis issues (FindBugs and Intellij IDEA analysis)
Diffstat (limited to 'src/main/java/au/id/zancanaro/javacheck/RoseTree.java')
-rw-r--r-- | src/main/java/au/id/zancanaro/javacheck/RoseTree.java | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/main/java/au/id/zancanaro/javacheck/RoseTree.java b/src/main/java/au/id/zancanaro/javacheck/RoseTree.java index 86952da..5a54d6f 100644 --- a/src/main/java/au/id/zancanaro/javacheck/RoseTree.java +++ b/src/main/java/au/id/zancanaro/javacheck/RoseTree.java @@ -36,8 +36,9 @@ public class RoseTree<T> { } private static <T> Iterator<RoseTree<T>[]> permutations(RoseTree<T>[] trees) { - return Iterators.flatten(Iterators.rangeIterator(trees.length, index -> - Iterators.mappingIterator(child -> { + return Iterators.flatten( + Iterators.rangeIterator(trees.length, + index -> Iterators.mappingIterator(child -> { @SuppressWarnings("unchecked") RoseTree<T>[] result = (RoseTree<T>[]) new RoseTree[trees.length]; for (int i = 0; i < trees.length; ++i) { @@ -45,14 +46,14 @@ public class RoseTree<T> { } return result; }, trees[index].getChildren()) - )); + )); } public static <T, R> RoseTree<R> zip(Function<List<T>, R> fn, RoseTree<T>[] trees) { @SuppressWarnings("unchecked") List<T> heads = new ArrayList(trees.length); - for (int i = 0; i < trees.length; ++i) { - heads.add(trees[i].getValue()); + for (RoseTree<T> tree : trees) { + heads.add(tree.getValue()); } return new RoseTree<>( fn.apply(heads), |